Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

[Ander Juaristi]

Hi Tim,

On 11/18/2015 11:09 AM, Tim Ruehsen wrote:
> Hi Dagobert, hi Ander,
>
> I could reproduce and fix the problem on a 32bit Debian wheezy VM.
>
> @Dagobert Please check if the attached patch works on Solaris as well
> @Ander Please review that I did not get anything wrong

I moved the calls to xfree (kh->host) a few lines up because I couldn't pass the 
unit tests after applying your patch (64-bit Linux Mint). The reason was simply that 
kh->host had garbage, and thus free() complained.

And also:

    PASS: Test--post-file.px
    *** Error in `../src/wget': free(): invalid pointer: 0x0000000000d2c5f0 ***
    PASS: Test-proxied-https-auth.px
    *** Error in `../src/wget': free(): invalid pointer: 0x00000000021cc5f0 ***

@Dagobert please check that it still passes all the tests in Solaris 32-bit. 
For some reason I couldn't compile it on a 32-bit Debian, and had no time to 
look into it further.

> Tim

Regards,
- AJ

0001-Fix-HSTS-memory-issue-test-code-issue.patch
Description: Text Data