[Bug-wget] [bug #46537] Compilation of 1.17 fails when no SSL: 'using_data_security' undeclared

[Hannu Nyman]

URL:
  <http://savannah.gnu.org/bugs/?46537>

                 Summary: Compilation of 1.17 fails when no SSL:
'using_data_security' undeclared
                 Project: GNU Wget
            Submitted by: hnyman
            Submitted on: Thu 26 Nov 2015 09:05:42 AM GMT
                Category: Build/Install
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: trunk
        Operating System: GNU/Linux
         Reproducibility: Every Time
           Fixed Release: None
         Planned Release: None
              Regression: Yes
           Work Required: None
          Patch Included: None

    _______________________________________________________

Details:

When wget 1.17 is compiled without SSL support, the compilation fails:

ftp.c: In function 'getftp':
ftp.c:396:7: error: 'using_data_security' undeclared (first use in this
function)
       using_data_security = con->st & DATA_CHANNEL_SECURITY;
       ^
ftp.c:396:7: note: each undeclared identifier is reported only once for each
function it appears in

That is because on line 396 there is one statement with 'using_data_security'
outside the "ifdef HAVE_SSL" wrappers. 

http://git.savannah.gnu.org/cgit/wget.git/tree/src/ftp.c?id=v1.17#n396

The variable introduction is inside ifdef, which makes it unknown when no SSL
support is active:
http://git.savannah.gnu.org/cgit/wget.git/tree/src/ftp.c?id=v1.17#n336

The bug is due to commit
http://git.savannah.gnu.org/cgit/wget.git/commit/src/ftp.c?id=f8901af4e02d69c1d8cbedc5d344269d54a73498

Bug is present both in the released 1.17 code and the git master branch.


Ps.
release 1.17 is missing from the bug tracker's release dropdown.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46537>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/