[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Marking Release v1.17.1?
From: |
Gisle Vanem |
Subject: |
Re: [Bug-wget] Marking Release v1.17.1? |
Date: |
Wed, 16 Dec 2015 14:11:27 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
Eli Zaretskii wrote:
> + {
> +#ifdef WIN32
> + /* If the connection timed out, fd_close will hang in Gnulib's
> + close_fd_maybe_socket, inside the call to WSAEnumNetworkEvents. */
> + if (errno != ETIMEDOUT)
> +#endif
> + fd_close (sock);
> + }
> if (print)
> logprintf (LOG_NOTQUIET, _("failed: %s.\n"), strerror (errno));
> errno = save_errno;
I assume fd_close() could cause 'errno' to be set again (for some
strange reason?). So shouldn't 'save_errno' be printed instead?
if (print)
logprintf (LOG_NOTQUIET, _("failed: %s.\n"), strerror (save_errno));
Or a swap:
errno = save_errno;
if (print)
logprintf (LOG_NOTQUIET, _("failed: %s.\n"), strerror (errno));
--gv
- Re: [Bug-wget] Marking Release v1.17.1?, (continued)
- Re: [Bug-wget] Marking Release v1.17.1?, Jernej Simončič, 2015/12/10
- Re: [Bug-wget] Marking Release v1.17.1?, Jernej Simončič, 2015/12/11
- Re: [Bug-wget] Marking Release v1.17.1?, Gisle Vanem, 2015/12/12
- Re: [Bug-wget] Marking Release v1.17.1?, Jernej Simončič, 2015/12/12
- Re: [Bug-wget] Marking Release v1.17.1?, Eli Zaretskii, 2015/12/13
- Re: [Bug-wget] Marking Release v1.17.1?, Giuseppe Scrivano, 2015/12/16
- Re: [Bug-wget] Marking Release v1.17.1?, Eli Zaretskii, 2015/12/16
- Re: [Bug-wget] Marking Release v1.17.1?,
Gisle Vanem <=
- Re: [Bug-wget] Marking Release v1.17.1?, Eli Zaretskii, 2015/12/16
- Re: [Bug-wget] Marking Release v1.17.1?, Giuseppe Scrivano, 2015/12/16