[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Implement --pinnedpubkey option to pin public keys
From: |
Tim Ruehsen |
Subject: |
Re: [Bug-wget] Implement --pinnedpubkey option to pin public keys |
Date: |
Tue, 15 Mar 2016 12:50:07 +0100 |
User-agent: |
KMail/4.14.10 (Linux/4.4.0-1-amd64; KDE/4.14.14; x86_64; ; ) |
Hi Travis,
thanks for poking. I started testing... just a few more points.
In wg_pin_peer_pubkey(), what is this loop do {...} while(0) about ?
I looks like it is not supposed to loop (if it would, we had resource leaks).
Maybe you can remove it and instead of 'break: do a 'goto end/cleanup/out' !?
Please consider to use wget_read_file / wget_read_file_free() for reading the
contents of a file. It also allows for stdin ('-' at the command line) which
makes the new option a bit more consistent with Wget's CLI standards.
Do you plan to create a python test (see testenv/) ?
Regards, Tim
On Monday 14 March 2016 12:57:52 moparisthebest wrote:
> Hi all,
>
> Just checking back in about this patch, is there anything else you are
> waiting on from me before integrating it?
>
> Thanks much,
> Travis
signature.asc
Description: This is a digitally signed message part.