[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Wget - acess list bypass / race condition PoC
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] Wget - acess list bypass / race condition PoC |
Date: |
Wed, 24 Aug 2016 12:30:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi,
Eli Zaretskii <address@hidden> writes:
>> #else /* def __VMS */
>> - *fp = fopen (hs->local_file, "wb");
>> + if (opt.delete_after
>> + || opt.spider /* opt.recursive is implicitely true */
>> + || !acceptable (hs->local_file))
>> + {
>> + *fp = fdopen (open (hs->local_file, O_CREAT | O_TRUNC |
>> O_WRONLY, S_IRUSR | S_IWUSR), "wb");
>> + }
>
> For this to work on MS-Windows, the 'open' call should use O_BINARY,
> in addition to the other flags. Otherwise, the "b" in "wb" of
> 'fdopen' will be ignored by the MS runtime.
FYI: I have pushed the two patches, with the fix amended.
Cheers,
Giuseppe
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC, (continued)
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC, Giuseppe Scrivano, 2016/08/18
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC, Tim Rühsen, 2016/08/18
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC, Misra, Deapesh, 2016/08/18
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC, Giuseppe Scrivano, 2016/08/21
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC, Eli Zaretskii, 2016/08/21
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC, Giuseppe Scrivano, 2016/08/21
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC,
Giuseppe Scrivano <=
- Re: [Bug-wget] Wget - acess list bypass / race condition PoC, Kurt Seifried, 2016/08/21