Re: [Bug-wget] wget 1.19.2 fails on Test-metalink-http.py and Test-metalink-http-quoted.py

[Tim Rühsen]

Thanks,

slightly amended and pushed.


With Best Regards, Tim



On 01/30/2018 09:42 AM, Arkadiusz Miśkiewicz wrote:
> On Monday 30 of October 2017, Tim Rühsen wrote:
>> On 10/30/2017 12:49 PM, Arkadiusz Miśkiewicz wrote:
>>> On Monday 30 of October 2017, Tim Rühsen wrote:
>>>> On 10/29/2017 09:39 PM, Arkadiusz Miśkiewicz wrote:
>>>>> On Sunday 29 of October 2017, Tim Rühsen wrote:
>>>>>> On Sonntag, 29. Oktober 2017 21:00:35 CET Arkadiusz Miśkiewicz wrote:
>>>>>>> On Sunday 29 of October 2017, Tim Rühsen wrote:
>>>>>>>> On Sonntag, 29. Oktober 2017 13:45:53 CET Arkadiusz Miśkiewicz wrote:
>>>>>>>>> Hi.
>>>>>>>>>
>>>>>>>>> Test suite for wget fails here on Test-metalink-http.py and
>>>>>>>>> Test-metalink- http-quoted.py
>>>>>>>>>
>>>>>>>>> test-suite.log attached.
>>>>>>>>
>>>>>>>> Could you please also send us the file 'config.log' ? That shows
>>>>>>>> your configuration - I would like to reproduce that issue.
>>>>>>>
>>>>>>> Attached.
>>>>>>
>>>>>> I meant config.log, you attached config.h.
>>>>
>>>> Looks pretty identical to mine.
>>>>
>>>> That made me looking a bit deeper into the original .log file, where you
>>>> can see that python file name structure dump. Well, this is that
>>>> additional file found in the temp. test directory. The test(s) expect
>>>> certain file and their correct contents after running... with those two
>>>> tests we see an additional (unexpected) file named
>>>> '.gnupg/dirmngr.conf'.
>>>>
>>>> My guess is that this is created by the use of gpgme which calls gnupg
>>>> functions. And it has something to do with dirmngr configuration.
>>>> Please have a look at your configuration.
>>>
>>> Thanks.
>>>
>>> Added patch below (locally in my wget build) to avoid dependency on some
>>> specific gnupg/dirmngr configuration. It fixes both tests for me.
>>>
>>> --- wget-1.19.2/testenv/conf/expected_files.py.org  2017-10-30
>>> 12:36:46.911716601 +0100 +++
>>> wget-1.19.2/testenv/conf/expected_files.py  2017-10-30 12:41:03.358656484
>>> +0100
>>>
>>> @@ -24,9 +24,9 @@ class ExpectedFiles:
>>>          snapshot = {}
>>>          
>>>          for parent, dirs, files in os.walk('.'):
>>>              for name in files:
>>> -                # pubring.kbx will be created by libgpgme if $HOME
>>> doesn't contain the .gnupg directory. +                # pubring.kbx,
>>> dirmngr.conf, gpg.conf can be created by libgpgme if $HOME doesn't
>>> contain the .gnupg directory.
>>>
>>>                                      # setting $HOME to CWD (in 
>>> base_test.py) breaks two Metalink
>>>                                      tests, so we skip this file here.
>>>
>>> -                if name == 'pubring.kbx':
>>>
>>> +                if name in [ 'pubring.kbx', 'dirmngr.conf', 'gpg.conf' ]:
>>>                      continue
>>>                  
>>>                  f = {'content': ''}
>>
>> Great, thanks ! The changes are pushed.
>>
>> Sorry that I didn't find/remember this immediately:
>> commit 5d4ada1b7b0b79f8053f3d6ffddda2e2c66d9dce
>> Author: Tim Rühsen <address@hidden>
>> Date:   Tue May 16 10:24:52 2017 +0200
>>
>>     Fix two Metalink tests if $HOME is changed
>>
>>     * conf/expected_files.py (gen_local_fs_snapshot): Skip processing
>>       of 'pubring.kbx'
>>
>> :-)
>>
>> With Best Regards, Tim
> 
> And one more file can be created by libgpgme:
> 
> --- wget-1.19.4/testenv/conf/expected_files.py.org    2018-01-30 
> 09:36:46.359579482 +0100
> +++ wget-1.19.4/testenv/conf/expected_files.py        2018-01-30 
> 09:37:01.350209794 +0100
> @@ -24,9 +24,9 @@ class ExpectedFiles:
>          snapshot = {}
>          for parent, dirs, files in os.walk('.'):
>              for name in files:
> -                # pubring.kbx, dirmngr.conf, gpg.conf will be created by 
> libgpgme if $HOME doesn't contain the .gnupg directory.
> +                # pubring.gpg, pubring.kbx, dirmngr.conf, gpg.conf will be 
> created by libgpgme if $HOME doesn't contain the .gnupg directory.
>                  # setting $HOME to CWD (in base_test.py) breaks two Metalink 
> tests, so we skip this file here.
> -                if name in [ 'pubring.kbx', 'dirmngr.conf', 'gpg.conf' ]:
> +                if name in [ 'pubring.gpg', 'pubring.kbx', 'dirmngr.conf', 
> 'gpg.conf' ]:
>                      continue
>  
>                  f = {'content': ''}
> 
>

signature.asc
Description: OpenPGP digital signature