ospf_snmp.c seems to be broken.

[Mattias Webjörn Eriksson]

Hello.
I posted a patch on the zebra mailing list just after the initial
release of zebra-0.93 about ospf_snmp.c beeing unable to compile
(./configure --enable-snmp).The problem still exists in zebra-0.93a.

Have people stopped using snmp with zebra, what is the status?
Is snmp not prioritized? I think build errors are quit serious, though.

bgpd and zebrad builds without errors.

These are the errors that I get from ospf_snmp.c:


b    -g -O2 -Wall -I/usr/include/ucd-snmp -c `test -f 'ospf_routemap.c' ||
echo './'`ospf_routemap.c
source='ospf_snmp.c' object='ospf_snmp.o' libtool=no \
depfile='.deps/ospf_snmp.Po' tmpdepfile='.deps/ospf_snmp.TPo' \
depmode=gcc /bin/sh ../depcomp \
gcc -DHAVE_CONFIG_H  -DSYSCONFDIR=\"/etc/zebra/\" -I. -I. -I.. -I.. -I..
-I../lib    -g -O2 -Wall -I/usr/include/ucd-snmp -c `test -f 'ospf_snmp.c'
|| echo './'`ospf_snmp.c
ospf_snmp.c: In function `ospfAreaRangeLookup':
ospf_snmp.c:1140: warning: passing arg 2 of `ospf_area_range_lookup' from
incompatible pointer type
ospf_snmp.c: In function `ospfAreaRangeEntry':
ospf_snmp.c:1220: structure has no member named `node'
ospf_snmp.c: In function `ospfHostLookup':
ospf_snmp.c:1271: warning: implicit declaration of function
`ospf_nbr_nbma_lookup_by_addr'
ospf_snmp.c:1271: warning: assignment makes pointer from integer without a
cast
ospf_snmp.c: In function `ospfIfEntry':
ospf_snmp.c:1656: structure has no member named `status'
ospf_snmp.c:1656: warning: left-hand operand of comma expression has no
effect
ospf_snmp.c:1665: structure has no member named `status_change'
ospf_snmp.c:1665: warning: left-hand operand of comma expression has no
effect
ospf_snmp.c: In function `ospfVirtIfEntry':
ospf_snmp.c:1996: structure has no member named `status'
ospf_snmp.c:1996: warning: left-hand operand of comma expression has no
effect
ospf_snmp.c:1999: structure has no member named `status_change'
ospf_snmp.c:1999: warning: left-hand operand of comma expression has no
effect
ospf_snmp.c: In function `ospf_snmp_nbr_lookup':
ospf_snmp.c:2034: structure has no member named `status'
ospf_snmp.c:2026: warning: `nbr' might be used uninitialized in this
function
ospf_snmp.c: In function `ospf_snmp_nbr_lookup_next':
ospf_snmp.c:2062: structure has no member named `status'
ospf_snmp.c:2053: warning: `nbr' might be used uninitialized in this
function
ospf_snmp.c: In function `ospfNbrEntry':
ospf_snmp.c:2176: structure has no member named `status'
ospf_snmp.c:2176: warning: left-hand operand of comma expression has no
effect
make[2]: *** [ospf_snmp.o] Error 1
make[2]: Leaving directory
`/usr/local/slackbuilds/zebra/zebra-0.93a/ospfd'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/local/slackbuilds/zebra/zebra-0.93a'
make: *** [all] Error 2





Best Regards
Mattias Webjörn Eriksson