Re: [Bug-zile] Crash on file oddities fixed?

[Reuben Thomas]

On 13 April 2011 02:41, Gary V. Vaughan <address@hidden> wrote:
> All the more reason for an exhaustive testsuite with good coverage :)

Indeed, but I'm also on the lookout for lint-like tools (we already
have strict.lua built in, which helps, but static analysis would also
help; a truly exhaustive test suite + strict does have the same
effect, though).

> Thanks... you forgot to patch the original bug though.  I committed
> the fix, hope you don't mind.

I didn't forget, I just didn't spot it!

> Still looks like a fixable Lua bug to me.  HEAD now gives me two
> terminal bells and a very short-lived error message flashes up in
> the minibuffer:
>
>  cannot make backup file: %s
>
> Quickly overwritten by:
>
>  Wrote /Users/me/.mutt/muttrc
>
> So a few things are still wrong:
>
>  i) posix.errno() is not returning an error message at file.lua:369

No, it's a missing call to string.format. I've added this one and a
couple of others I found by grepping.

>  ii) copy_file is not working at file.lua:365

So it looks like create_backup_filename is failing.

> iii) waitkey is not waiting for a key before overwriting the partial
>     error message at file.lua:370

On the whole waitkey seems to me to work, and I'm at a loss to see
what could be going wrong at this particular site (unless you're
pressing a key!) so more help welcomed...

-- 
http://rrt.sc3d.org