Re: [Bug-zile] [PATCH] term: optimise make_char_printable for ASCII

[Gary V. Vaughan]

> On 13 December 2011 05:32, Gary V. Vaughan <address@hidden> wrote:
>> Since this code already assumes ASCII in that \01 through \032 will
>> map to A-Z contiguously, we can optimise it some more for \0 and \033
>> which are in the same range.
>> 
>> Okay to push?

On 13 Dec 2011, at 18:48, Reuben Thomas wrote:
> What about EBCDIC? (Theoretically, Zile ought to be fine on any 8-bit
> character set.)

We were already hosed on EBCDIC, because of assumptions about A-Z being
contiguous in the existing code (as well as assumptions that, say tab is
the same distance from I as ret is from J).

In my experience it's almost impossible to accidentally support EBCDIC.
Certainly with a lot of care and a bit of testing it is not terribly
difficult to rewrite all the character twiddling, but lua zile (and most
likely the equivalent code in C Zile) do not currently support it.

Anyway, this patch doesn't make things any worse for EBCDIC support, but
makes the code a little faster and clearer on ASCII machines.

Is it worth the effort of auditing for EBCDIC compatibility?

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)