[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] alist-update: don't segfault on non-list
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] alist-update: don't segfault on non-list |
Date: |
Thu, 6 Jun 2013 21:21:52 +0200 |
User-agent: |
Mutt/1.4.2.3i |
On Thu, Jun 06, 2013 at 09:16:52PM +0200, Peter Bex wrote:
> On Thu, Mar 14, 2013 at 05:43:46AM +0100, Florian Zumbiehl wrote:
> > Check the alist passed to alist-update is actually a pair before
> > using ##sys#slot on it.
>
> This one almost slipped through the cracks. It's a trivial change, so
> I decided that a second signoff is not neccessary, and pushed it
> immediately.
And of course only now I noticed the preceding discussion.... (-(
It didn't really lead to anything, and adding the check in front
would cause it to traverse the list twice. I think I prefer the
traverse-once over check-and-traverse even if this would catch
some more error situations.
If you disagree, feel free to continue the discussion and revise.
Cheers,
Peter
--
http://www.more-magic.net