chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix #892 by causing panic instead of crash


From: Moritz Heidkamp
Subject: Re: [Chicken-hackers] [PATCH] Fix #892 by causing panic instead of crash/segfault upon heap exhaustion
Date: Sun, 28 Jul 2013 20:37:19 +0200

Hi Peter,

Peter Bex <address@hidden> writes:
> I remembered that normally when going out of memory, we get a "heap full
> while resizing" panic.  Attached is an even simpler patch which removes
> the (seemingly bogus?) check whether the new size equals the old size,
> and will simply carry on reclaiming, thereby triggering the familiar
> error message.  This should simplify matters a bit.

good job finding the root cause of this issue! Tests still pass and the
reproduction case from the ticket terminates with a sensible error
now. As far as I can tell the change is good and thus I signed it off
and pushed it.

Thanks!
Moritz



reply via email to

[Prev in Thread] Current Thread [Next in Thread]