[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Another subtle GC problem
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] Another subtle GC problem |
Date: |
Wed, 23 Oct 2013 11:46:45 +0200 |
User-agent: |
Mutt/1.4.2.3i |
On Wed, Oct 23, 2013 at 11:43:24AM +0200, Moritz Heidkamp wrote:
> looks OK and works fine AFAICT. Pushed!
Thanks!
> > When shrinking the heap, this check won't need to be run because
> > we've just done a GC, so there *should be* no pressure on
> > the nursery, so it won't get copied to the heap. But I don't
> > fully grok this part yet, so don't take my word for it.
>
> So this would get rid of one comparsion operation per major GC?
No, the patch adds an *extra* comparison per major GC. I was just
really thinking out loud, because I was a little worried that the
resizing logic for adding the stack size might be broken when
*shrinking* the heap. But like I said, I think it works due to the
fact that shrinking only happens after performing a minor GC.
Cheers,
Peter
--
http://www.more-magic.net