[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Add proper list checks to assq/assv/assoc
|
From: |
Moritz Heidkamp |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Add proper list checks to assq/assv/assoc and memq/memv/member |
|
Date: |
Mon, 27 Jan 2014 13:06:48 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Hey Peter,
Peter Bex <address@hidden> writes:
> Thanks for this one.
thanks for reviewing!
> You somehow missed C_i_memv, though, which resulted in library-tests
> to fail. So at least the tests are complete :)
Hm, that's weird, I was sure I had given it a final run. Anyway, I might
be missing something but my patch actually does cover C_i_memv (lines
73-82), doesn't it? AFAICT you added another check to C_u_i_memq,
referring to memv in the error message. But isn't the point of C_u_*
variants to be unchecked?
Note that I made a bootstrap build before running the tests. Maybe
that's why the tests didn't fail for me?
Thanks again and cheers!
Moritz