[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix #1347 and static linking when cross-co
From: |
Evan Hanson |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix #1347 and static linking when cross-compiling with customised target library name |
Date: |
Wed, 8 Mar 2017 17:34:43 +1300 |
Hi Peter,
This looks OK to me, and it tests fine on the platforms I've tried
(Solaris notwithstanding, but that's unrelated; see #1350).
Pushed.
Thanks, Peter.
On 2017-03-05 17:04, Peter Bex wrote:
> I can't explain why it doesn't break on master, but it might have
> something to do with the many changes in loading of units that we've
> made, or the difference in what modules are available by default.
That's basically right: we've never tested static linking on master.
Those tests were added during the work on code loading, in f0aafa06
(which is only in chicken-5, of course).
> I'm assuming the cross-compilation bug exists in master as well, in
> which case we might decide to fix that as well? For now I don't think
> it's that important (not many people customize the target library
> name?)
Probably, but I agree it isn't a high priority and I'm inclined to
ignore it until someone complains.
Cheers,
Evan
signature.asc
Description: PGP signature