Re: [Chicken-janitors] #668: Issue with 49b92ba0bfb7ecfceb49a45f64e9943ea83a6d94

[Chicken Trac]

#668: Issue with 49b92ba0bfb7ecfceb49a45f64e9943ea83a6d94
-----------------------+----------------------------------------------------
  Reporter:  mario     |       Owner:                                          
      Type:  defect    |      Status:  closed                                  
  Priority:  critical  |   Milestone:  4.8.0                                   
 Component:  unknown   |     Version:  4.7.x                                   
Resolution:  fixed     |    Keywords:  49b92ba0bfb7ecfceb49a45f64e9943ea83a6d94
-----------------------+----------------------------------------------------
Changes (by felix):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 The fix is so trivial, it hurts:

 {{{
 diff --git a/scheduler.scm b/scheduler.scm
 index 08c8a5c..02a8fad 100644
 --- a/scheduler.scm
 +++ b/scheduler.scm
 @@ -436,7 +436,7 @@ EOF
                             [inf (##core#inline "C_fd_test_input" fd)]
                             [outf (##core#inline "C_fd_test_output" fd)])
                        (dbg "fd " fd " state: input=" inf ", output="
 outf)
 -                      (if (or inf outf errf)
 +                      (if (or inf outf)
                            (let loop2 ((threads (cdr a)) (keep '()))
                              (if (null? threads)
                                  (if (null? keep)
 }}}

 Since unbound variable checks are disabled in this code, the reference
 would result in thh test being always true.

 I will apply this directly to master, there is not much reason to review
 it.

-- 
Ticket URL: <http://bugs.call-cc.org/ticket/668#comment:10>
Chicken Scheme <http://www.call-with-current-continuation.org/>
Chicken Scheme is a compiler for the Scheme programming language.