|
From: | Dan Leslie |
Subject: | Re: [Chicken-users] New string manipulation module |
Date: | Wed, 20 Feb 2013 10:24:59 -0800 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 |
Nice work, contributions are greatly
appreciated. :)
Since you're asking for constructive feedback, two things come to mind: It's a matter of taste, but IMHO it's schemier that descriptive-variable is preferable to desc-var, so in your case s-foo could easily be string-foo. However, I would drop the prefix altogether, as Chicken supports renaming on import. So string-foo would become foo and any prefixing is left up to the user of your library. I'm not certain what you intended by 'official', but if you meant that you'd like to see it packaged with Chicken then perhaps you should consider switching the license to Chicken's license. Mind you, GPL3 eggs are happily accepted, but note that many folks won't touch them for various reasons. However, if this is a port of an elisp library then likely re-licensing is not an option. Anyhow, thanks for the hard work and the contribution! And welcome to Chicken-land, come join us on IRC if you get a chance. Thanks, -Dan On 2/20/2013 9:36 AM, Nicholas Van Horn wrote:
|
[Prev in Thread] | Current Thread | [Next in Thread] |