classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Fix for DatagramSocket


From: Steven Augart
Subject: Re: [cp-patches] Fix for DatagramSocket
Date: Sun, 18 Jul 2004 20:37:00 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616

Archie Cobbs wrote:
The file gnu_java_net_PlainDatagramSocketImpl.c has a bug where it
sets the port in the received datagram byte-swapped. This is because
it thinks it needs to byte-swap it, which is incorrect, because it's
already been byte-swapped earlier by the
TARGET_NATIVE_NETWORK_SOCKET_RECEIVE_WITH_ADDRESS_PORT() macro
(which is invoked from _javanet_recvfrom()).

This patch fixes it... I'll commit if there are no complaints.

I'm a little suspiciou though whether I'm the only one seeing this.
For me this bug always causes the Mauve test suite to hang indefinitely
during the "gnu.testlet.java.net.DatagramSocket.DatagramSocketTest" test,
so I'd think other people would have noticed it before.

We've been disabling that test in the nightly Jikes RVM CVS regressions against Mauve, specifically because it kept hanging. We'd assumed it was a bug in our own implementation.

I'm glad you caught the bug.  Thank you.

--Steve Augart


--
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm




reply via email to

[Prev in Thread] Current Thread [Next in Thread]