RE: [cp-patches] Proposed patch: java.io.File

[Jeroen Frijters]

Michael Koch wrote:
> Am Donnerstag, 22. Juli 2004 13:30 schrieb Jeroen Frijters:
> > I'd like to merge in better Windows path support from libgcj (plus
> > some extra fixes). This is a rather large (and complicated) patch.
> > It removes the dependency on gnu.java.io.PlatformHelper (I would
> > like to remove this class completely in the near future). Another
> > consequence of this patch is basically that we from now on only
> > support Unix and Windows style paths. If anyone has problems with
> > that, I will move the platform specific stuff to VMFile.
> >
> > I also had to introduce a new toCanonicalForm() method in VMFile,
> > because this needs native support on Windows.
> 
> The changes in VMFile are missing in the patch.

Yeah, that was intentional. I haven't made those changes yet, because I
don't know how to do it. The most obvious way would be to add a native
toCanonicalForm method to VMFile and then use the native code from
libgcj, but I don't have the setup/knowledge to do this.

> In general I'm for this patch. If it doesn't introduce new mauve 
> regressions I would say: please commit.

For me (on Windows) it introduced one regression in URL, but that was a
bug in URL (it canonicalized a path where it shouldn't). I will submit
that patch soon.

Thanks for reviewing.

Regards,
Jeroen