Re: [cp-patches] FYI: Geom updates in.

[Mark Wielaard]

Hi,

On Mon, 2004-08-02 at 01:16, Sven de Marothy wrote:
> I just commited the patch I submitted on the main mailing list
> earlier. (So I'm not re-posting it here)
> 
> * java/awt/geom/CubicCurve2D - implemented contains()/intersects()
> * java/awt/geom/QuadCurve2D - likewise
> * java/awt/geom/GeneralPath - Implemented in full
> * java/awt/geom/RoundRectangle2D - Several bugs fixed. (Bug #6067)

Thanks a lot for your hard work on this.

One little (but important!) nit.
You should always add a ChangeLog entry for every change.
I added the following:

2004-08-01  Sven de Marothy  <address@hidden>

       * java/awt/geom/CubicCurve2a.javaD: Reindent.
       (contains): Implemented.
       (intersects): Implemented.
       * java/awt/geom/QuadCurve2D.java: Likewise.
       * java/awt/geom/GeneralPath: Reindent and document.
       Fully (re)implemented using separate xpoints and ypoints
       float[] coords.
       * java/awt/geom/RoundRectangle2D: Several bugfixes (Bug #6007).

You can find an example of how to write good ChangeLog entries in the
GNU Classpath Hacker Guide (7.1 Documenting what changed when with
ChangeLog entries):
http://www.gnu.org/software/classpath/docs/hacking.html#SEC9

It is important to have an accurate ChangeLog because it documents what
was actually intended to be committed (there is always the possibility
that you make a mistake while committing) and it is a way to track the
changes between the different trees (this was why I found the ChangeLog
entry missing, I could see that the libgcj gui branch differed from GNU
Classpath CVS, but couldn't easily find when what changed in each tree.
I had the mailinglist and CVS logs, but when comparing two release
tarballs offline the ChangeLogs are indispensable).

Sorry for being pedantic and keep on hacking!

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part