Re: [cp-patches] Patch: RFC: VMCompiler

[Mark Wielaard]

Hi,

On Wed, 2004-08-11 at 20:01, Tom Tromey wrote:
> For gcj-jit we may finally have a reason to use parts of
> java.lang.Compiler.  In particular I'm thinking we might want to use
> Compiler.enable() and Compiler.disable() to let folks indicate whether
> they want gcj-jit to be used.
> 
> So, I wrote this patch to turn Compiler into a simple wrapper around
> VMCompiler.  Any comments on this?

I think the patch is fine. Although I am not sure the original
java.lang.Compiler interface is very useful. Be careful that by
implementing hooks into your JIT you don't introduce any security
issues. (Since there are no standard security check around these methods
anybody at any time from any thread can call them. Disabling the JIT is
at least a quality of service issue.) 

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part