Re: [cp-patches] Documentation for java.util.Collections

[Andrew John Hughes]

On Wed, 2004-09-01 at 07:16, Mark Wielaard wrote:
> Hi,
> 
> On Tue, 2004-08-24 at 21:55, Andrew John Hughes wrote:
> > This patch adds documentation corrections and additions
> > to java.util.Collections.  I've had this one lying around for
> > a while -- I'd forgotten I had to split it off from the last
> > util post due to its size.  Still pretty big though, so my apologies.
> 
> This is great. Thanks.
> 
> The only reason I didn't say "yes, please commit!" yet was that it has
> the following kind of examples in SortedSet example that I must admit
> just didn't get immediatly:
> 
> +     * The returned map throws an IllegalArgumentException any time a key is
> +     * used which is out of the range of fromKey. Note that the endpoint is
> +     * included; if you do not want the endpoint, pass the successor object 
> in
> +     * to fromKey.  For example, for Strings, you can request
> +     * <code>tailMap(limit + "\0")</code>.
> 
> Adding a 'null' character to a String doesn't look like a clean example,
> it looks more like a quick hack that happens to work in this case. (It
> depends on good knowledge of the String comparator.) Maybe you can give
> a little clearer (more intuitive) example with Integers objects?
> 
> Cheers,
> 
> Mark

Yes, I agree.  I couldn't quite get my head round it myself, and I
honestly don't know why I didn't pull it (I didn't write it -- its
copied more or less verbatim from the one in the SortedSet interface,
and I probably should have altered it then).  I change it and re-submit
the patch.

Cheers,
-- 
Andrew :-)
 
Please avoid sending me Word or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html
 
Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn.

signature.asc
Description: This is a digitally signed message part