classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch for AWT menu accessibility


From: Thomas Fitzsimmons
Subject: Re: [cp-patches] Patch for AWT menu accessibility
Date: Fri, 10 Sep 2004 10:43:40 -0400

On Tue, 2004-08-31 at 21:43, Andrew John Hughes wrote:
> The attached patch adds the accessibility classes to the abstract
> MenuComponent, and its subclass Menu.  It seems to me that Sun
> haven't actually finished the job here (and the docs for 1.3 suggest
> this too).  MenuComponent specifies a fair amount of accessibility
> information, but the concrete classes only override a very minimal
> amount.  To my mind, there is not enough information in MenuComponent
> to provide what is required by the accessibility class.  Why it doesn't
> derive from Component I don't know, as it seems to re-implement most of
> its functionality.
> 

> +   * @serial true if events are to be processed locally.
> +   */
> +  private boolean newEventsOnly;

We don't use this field in our implementation so the comment should
probably just say "Unused".  Otherwise this looks great.  Please commit.

Tom






reply via email to

[Prev in Thread] Current Thread [Next in Thread]