classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC: java.beans.PropertyDescriptor.java - new methods a


From: Mark Wielaard
Subject: Re: [cp-patches] RFC: java.beans.PropertyDescriptor.java - new methods and equals()
Date: Fri, 12 Nov 2004 13:34:28 +0100

Hi Robert,

On Sun, 2004-11-07 at 20:39, Robert Schuster wrote:
> this patch simply adds setWriteMethod() and setReadMethod() (@since 
> 1.1?) and provides an implementation of equals() (which was introduced 
> in 1.4).
> 
> The patch looks bigger as it is. I had to rework parts of the private 
> method checkMethod() to let it operate on argument instead of instance 
> variables.

And it contained somereindenting. Which made it look like there was a
lot more rewritten than actually was. Thanks for cleaning this up
though.

> +2004-11-07  Robert Schuster <address@hidden>
> +
> +     Complete 1.4 support
> +     * java/beans/PropertyDescriptor.java:
> +     (setReadMethod): New method
> +     (setWriteMethod): New method
> +     (equals): Implemented (1.4)
> +     (checkMethods): operates on arguments now (private)

Saw you didn't commit this yet. Please do, it looks good.

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]