classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: FileDescriptor.sync() SyncFailedException clarificatio


From: Mark Wielaard
Subject: [cp-patches] FYI: FileDescriptor.sync() SyncFailedException clarification
Date: Fri, 10 Dec 2004 15:07:40 +0100

Hi,

Another small clarification to a thrown exception. This actually helps
to make the Eclipse logging system not crash and burn when it encounters
a SyncFailedException with a null message (which it will try to log
without checking whether or not it is null...).

2004-12-07  Mark Wielaard  <address@hidden>

        * java/io/FileDescriptor.java (Sync): Add real exception to
        SyncFailedException.

In practise there seems to be a deeper bug when this occurs since when
this is thrown it is normally because force() is called on a closed
FileChannel. I have not yet found out in which cases this is happening.

Committed,

Mark

diff -u -r1.23 FileDescriptor.java
--- java/io/FileDescriptor.java 2 Oct 2004 08:44:39 -0000       1.23
+++ java/io/FileDescriptor.java 10 Dec 2004 14:04:27 -0000
@@ -120,7 +120,7 @@
            if (ex instanceof SyncFailedException)
              throw (SyncFailedException) ex;
            else
-             throw new SyncFailedException(ex.getMessage());
+             throw new SyncFailedException(ex.toString());
          }
       }
   }

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]