Re: [cp-patches] StringBuilder and Appendable for CVS HEAD

[Andrew John Hughes]

On Tue, 2004-12-14 at 18:07, Michael Koch wrote:
> Am Dienstag, 14. Dezember 2004 18:17 schrieb Jeroen Frijters:
> > Andrew John Hughes wrote:
> > > I agree; but this is code which has sat in the generics branch
> > > for several months, not something that has just been put
> > > together.  Also, this is something which will allow Classpath to
> > > work with existing code that just happens to be compiled with a
> > > 1.5 compiler (which does a StringBuffer for StringBuilder
> > > substitution in String use) but has no actual 1.5 changes.
> >
> > I reviewed the patch and thought about the co-variant return type
> > issue and I think it is safe to put in.
> >
> > However, note that the current implementation is not correct
> > (thread/memory model safe). It's going to be quite tricky to
> > efficiently convert a StringBuilder into a String without creating
> > potential security holes.
> 
> We should not introduce code that is potentially insecure in current 
> state.
> 
> 
> Michael

Agreed wholeheartedly.  I didn't realise there were such problems with
the code (most of which was written by Tromey for the generics branch). 
What changes need to be made to make this patch usable?

Thanks,
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint) attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

"We've all been part of the biggest beta test the world has ever known --
Windows"
-- Victor Wheatman, Gartner

signature.asc
Description: This is a digitally signed message part