Re: [cp-patches] RFC: fix for #11255 and other JComboBox problems - UPDATE 1

[Michael Koch]

Am Samstag, 18. Dezember 2004 19:14 schrieb Robert Schuster:
> Forget the ChangeLog entry for the patch. Here it is:
>
> 2004-12-18  Robert Schuster <address@hidden>
>
>     * javax/swing/JComboBox.java
>     added support for no item being selected
>     (JComboBox): select first or nothing depending on element
>     count
>     (setModel): cleaned up unneeded "this." usage, added more
>     docs, made exception behavior match that of the JDK
>     (setLighWeightPopupEnabled): removed unneeded "this." usage
>     (setEditable): dito
>     (setMaximumRowCount): dito
>     (setRenderer): dito
>     (setPrototypeDisplayValue): dito
>     (getSelectedItem): simplified, added more user doc
>     (setSelectedIndex): corrected exception behavior, added more
> user doc
>     (getSelectedIndex): fixed hardcoded dependency on
> DefaultComboBoxModel (see bug #11255), added performance warning to
> user doc (addItem): fixed exception behavior, added user doc
>     (insertItemAt): dito
>     (removeItem): dito
>     (removeItemAt): dito
>     (removeAll): fixed exception behavior, added user doc, added
> support for model not being instance of DefaultComboBoxModel (see
> bug #11255) (getSelectedItemObjects): simplified
>     (getItemCount): fixed dependency on DefaultComboBoxModel (see
> bug #11255)
>     (getItemAt): fixed dependency on MutableComboBoxModel (see bug
> #11255) * javax/swing/DefaultComboBoxModel.java:
>     (setSelectedItem): updates selected item only if new
>     value is null or known (match JDK behavior)
>     * javax/swing/plaf/basic/BasicComboBoxUI.java:
>     (paintCurrentValue): renders "" if no item is selected

Please commit.


Michael
-- 
Homepage: http://www.worldforge.org/