Re: [cp-patches] New java.util.Currency implementation

[Michael Koch]

Am Mittwoch, 15. Dezember 2004 17:44 schrieb Andrew John Hughes:
> On Wed, 2004-12-15 at 09:02, Michael Koch wrote:
> > Am Mittwoch, 15. Dezember 2004 03:44 schrieb Andrew John Hughes:
> > > Attached is a new java.util.Currency implementation which uses
> > > iso4271.properties, as suggested by Michael Koch. The main
> > > problem in creating this was getting this resource into the
> > > installed Classpath, which I achieved in the end by adding it
> > > to the Makefile.am in resources/java/util.  If this is not the
> > > correct solution, please let me know.  It would also be nice to
> > > know if there is some documentation on this.  At least, I
> > > learnt a lot about classloaders and resources by trying
> > > different things ;)
> > >
> > > As far as this goes, we've gained some and lost some on the
> > > tests. We now have Euro support, but we've lost what little
> > > symbol support we had (although I think this is in line with
> > > Sun's implementation, but not the specification). The test file
> > > I have gives all decimal points as 2, but the tests suggest
> > > this is not always the case. This is most likely a bug in an
> > > early revision of the file.  We also still have a problem with
> > > getAllLocales() which has already been reported (the UK
> > > currency code lookup test fails because of this).
> > >
> > > Anyway, let me know your comments and the commit status,
> > > Cheers,
> >
> > Please don't add the ChangeLog entry to the patch. The ChangeLog
> > file changes too often to let the patch cleanly apply after some
> > time.
>
> Okay -- I wasn't aware of this, but it makes sense as they annoy me
> as well.
>
> > I will solve the Makefile.am issue by adding the same stuff we do
> > for java files for the resource files. This should make it
> > possible to just drop in new resource files without and changes
> > to any Makefile.am.
>
> Great -- that's really what it needs IMO.
>
> > I applied the patch locally and got a
> > java.lang.ExceptionInInitializerError with latest GNU classpath
> > CVS and a patched jamvm 1.2.1. I will investigate this more.
> >
> >
> > Michael
>
> Which is what I was getting when the resource was unlocatable, if
> that's any help.  The initialiser loads the properties file.

Can you please commit it now ?


Michael.
-- 
Homepage: http://www.worldforge.org/