[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [cp-patches] Thread.sleep() update
From: |
Jeroen Frijters |
Subject: |
RE: [cp-patches] Thread.sleep() update |
Date: |
Thu, 30 Dec 2004 16:44:00 +0100 |
Mark Wielaard wrote:
> And we would need at least good Mauve tests. I tried to write
> good ones before writing and testing this new implementation (of
> course Thread tests are always tricky so if I made any mistakes
> please point them out). If you could make additions to test for
> the behavior you expect here that would be nice.
I don't think it would be reasonable for Mauve to test for the behavior
I expect. It's clearly not part of the spec and most likely even Windows
specific.
Beyond the test that you added there isn't much else I can think off. My
local version of IKVM passes all tests (without your most recent change
to Thread.sleep) and JDK 1.5 (incorrectly) fails on
valid(Long.MAX_VALUE, 999999);
Regards,
Jeroen