Re: [cp-patches] Implementing Thread.sleep() via Thread.wait()

[Archie Cobbs]

Mark Wielaard wrote:
> Obviously I would have preferred the implementation of Thread.sleep()
> being pushed into VMThread.sleep() combined your suggested Object.wait()
> implementation. That would have kept documentation and mauve tests
> consistent. I can live with your interpretation and implementation as
> long as it is consistently used.  Since you have already committed the
> code you are responsible to update the documentation and mauve tests to
> reflect this (as I pointed out in my other email [*]). Since currently
> the documentation, tests and implementation are out of sync that should
> be fixed.

Hmm.. how about this: since there are two separate issues here,
let's separate them.

Issue #1 is adding the non-native VMThread.sleep() implementation,
which is not a problem for anyone.

Issue #2 is changing Thread.sleep(0) from testing for interrupt to
just doing Thread.yield().

My commit mixed #1 and #2, so for now I'll revert the #2 part, leaving
only the #1 part.

Then we can continue to decide what to do about #2. The net result is
that for the time being the behavior will be same it was before the new
VMThread.sleep() implementation, i.e., test for interrupted status.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com