RE: [cp-patches] Some VMStackWalker cleanups/simplifications

[Jeroen Frijters]

Mark Wielaard wrote:
> Here are a couple of cleanups/simplifications for the new 
> VMStackWalker.
> It fixes a nasty recursion in Class.getClassLoader() and it adds the
> Class that is interested in the actual calling class or classloader as
> argument to the VMStackWalker methods. This way it is much easier to
> generically check for skipping this class and the Method.invoke() call
> on the stack without depending on the actual stack depth.

Adding the Class parameter to getCallingClass[Loader] doesn't solve the
Method.invoke() scenario and adds way too much performance overhead to
be acceptable to me. This is optimizing for the wrong thing. If a VM
doesn't provide a custom VMStackWalker it's OK to be a little less
efficient, but the interface design should force the inefficiency on
every VM.

Regards,
Jeroen