Re: [cp-patches] RFC: ChannelReader #2

[Michael Koch]

Am Montag, 31. Januar 2005 23:35 schrieb Robert Schuster:
> Hi.
>
> >>However Channels had only a stub implementation for
> >>newReader(ReadableByteChannel, CharsetDecoder). I changed that by
> >>writing the adapter: gnu.java.nio.ChannelReader .
> >
> >Which isn't included in the patch :(  It's not just me then.
>
> Arg. Yes this is because I forgot to 'cvs add' the file :(
>
> >One thing that occurred to me from looking at the patch (without
> > the class, I couldn't compile).  If you remove the decoder
> > instance (replacing it with Reader), how do the other
> > constructors and the rest of the class still operate?
>
> gnu.java.io.decode.Decoder is a subclass of reader.
>
>
> Ok here is the same patch but now with the ChannelReader class
> included. I plan to clean up this thing in the next days (probably
> at weekend).
>
> @Michael: This patch does not make existing things slower.

I just wanted to make people aware of this problems, it would be good 
to add this to the Mediation Wiki.


Michael
-- 
Homepage: http://www.worldforge.org/