Re: [cp-patches] [Patch] small fixes in gnu.*

[Michael Koch]

On Wed, Mar 02, 2005 at 05:49:13PM +0000, Chris Burdess wrote:
> Michael Koch wrote:
> >I just commited the attached patch to fix some small issues in gnu.*.
> >     gnu/java/net/protocol/http/ChunkedInputStream.java,
> 
> I must say I'm not particularly happy about some of these changes. E.g. for 
> the above file:
> 
> 
> +++ gnu/java/net/protocol/http/ChunkedInputStream.java        2 Mar 2005 
> 17:27:07 -0000
> @@ -39,8 +39,8 @@
>   package gnu.java.net.protocol.http;
> 
>   import java.io.FilterInputStream;
> -import java.io.InputStream;
>   import java.io.IOException;
> +import java.io.InputStream;
>   import java.net.ProtocolException;
> 
> 
> 'n' comes before 'O' in English collation. This "fix" is a regression.

No. Uppercase charcters are ordered before lowercase. That is what
Eclipse and all other tools I looked do by default. I would have like it
the other way too but then I have to change the defaults everywhere.
We were inconsistent in this in the past, parts of the code uses this order,
other parts use the other order and most code used no real order before.


Michael
-- 
Java Trap: http://www.gnu.org/philosophy/java-trap.html