[cp-patches] Re: [commit-cp] classpath ./ChangeLog org/omg/CORBA/TypeCode.ja...

[Andrew John Hughes]

On Thu, 2005-03-03 at 19:12 -0500, Audrius Me?kauskas wrote:
> CVSROOT:      /cvsroot/classpath
> Module name:  classpath
> Branch:       
> Changes by:   Audrius Meškauskas <address@hidden>     05/03/04 00:12:15
> 
> Modified files:
>       .              : ChangeLog 
> Added files:
>       org/omg/CORBA  : TypeCode.java UserException.java 
>       org/omg/CORBA/TypeCodePackage: BadKind.java 
> 
> Log message:
>       2005-03-02  Audrius Meskauskas  <address@hidden>
>       
>       * org/omg/CORBA/TypeCode.java: new file
>       * org/omg/CORBA/UserException.java: new file
>       * org/omg/CORBA/TypeCodePackage/BadKind.java: new file
> 
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.3285&tr2=1.3286&r1=text&r2=text
> http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/org/omg/CORBA/TypeCode.java?rev=1.1
> http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/org/omg/CORBA/UserException.java?rev=1.1
> http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/org/omg/CORBA/TypeCodePackage/BadKind.java?rev=1.1
> 
> 
> 
> _______________________________________________
> Commit-classpath mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/commit-classpath
> 

Audrius,

        First of all, great work on finally getting us started with a CORBA
implementation.  There's been a lot of talk and procrastination about
this in the past, but no-one has yet (to my knowledge) set about
actually doing anything about it, code-wise.
        However, it is imperative that, after committing code, a clean checkout
will still compile.  Following the above patch, this wasn't the case.
This was probably due to a minor oversight, but with something like
Classpath, we have to be careful of such things.  There are people who
primarily use Classpath, rather than follow and help with its
development, and it would be unclear to them why the build has failed.
Obviously, this creates a negative impression of Classpath.
        GNU Classpath's CVS policy (at least as far as I know; someone correct
me if I'm wrong here) is pretty flexible.  You should always post a
patch prior to commit, but you can then do the commit unless the patch
is something major or ambiguous, where the comments of other Classpath
developers would be useful.  In the latter case, it would be useful if
you explicitly requested such comments.  I say this because I noted
there was a fair amount of inconsistency between the patches that were
posted here, and the actual commits (one of the files I used for this
fix was from one of your uncommitted patch posts).  Please try and make
sure that the human-readable patch posts and the commit messages match
up.

Thanks again for your work on GNU Classpath, and please take this simply
as a helpful reminder, rather than a personal attack.  I'm sure we've
all had similar false starts, but it pays to make things clear when
these situations occur.

Cheers,
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history. 
`Don't bother us with politics' respond those who don't want to learn." 
-- Richard Stallman

"We've all been part of the biggest beta test the world has ever known
--
Windows" 
-- Victor Wheatman, Gartner

signature.asc
Description: This is a digitally signed message part