Re: [cp-patches] FYI: streams

[Mark Wielaard]

Hi,

On Thu, 2005-03-03 at 10:29 +0100, Meskauskas Audrius wrote:
> 2005-03-03  Audrius Meskauskas  <address@hidden>
> 
>  * org/omg/CORBA/Object.java: new file (just to keep code compilable)
>  * org/omg/CORBA/ORB: new file (just to keep code compilable)
> [...]
> /**
>  * Not implemented, defined to keep the code compilable.
>  */

Make sure you add a FIXME in all capitals to such code. That makes it
much easier to find it back with a simple grep (of when your IDE has
support for finding TODO tags).

In the past we (I) added some stubs which were never fully filled in.
That was a mistake since it leads to code that compiles, but which don't
work. See the files in [gnu/]javax/rmi/CORBA/ for some examples of code
that is compilable but doesn't work at all (works wrongly even). With
your new code this can finally be fixed. Thanks.

But be careful with adding stubs unless you are 100% sure you will fix
them quickly. They have a tendency to be around for months or years
causing subtle (and not so subtle) bugs.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part