Re: [cp-patches] RFC: JNI implementation of Selector #1

[Michael Koch]

On Thu, Mar 17, 2005 at 06:49:50AM +0100, Robert Schuster wrote:
> Brings Sourceforge's current no2 most-often downloaded p2p app to life.
> 
> Well, this code is a straight adaption of GCJ's CNI equivalent. However two 
> bug reports have been created out of this.

Great work.

> Please review the patch and besides normal critique answer me the following 
> questions:
> 
> 1) Should we introduce a HAVE_SELECT switch as GCJ has?
> (If yes I need help with this.)

Just add "sys/select.h" into some AC_CHECK_HEADERS macro in configure.ac. Then 
you will
have HAVE_SYS_SELECT_H defined for free.
> 
> 2) strerror() is not thread-safe. Should I prefer strerror_r() which is less 
> portable?

We should probably check for strerror_r in configure.ac and just use it.
When some arch dont has it we can still work out a better way.


Michael
-- 
Java Trap: http://www.gnu.org/philosophy/java-trap.html