[cp-patches] FYI: fixlet for javax.swing.JPopupMenu.insert()

[Roman Kennke]

2005-06-01  Roman Kennke  <address@hidden>

       * javax/swing/JPopupMenu.java
       (insert): Do not check for index == -1 at this point, this is done
       in java.awt.Container. Catching -1 indices here disturbes the
       Container.addImpl which leads to bug #13247 for example.


The said bug #13247 should be fixed by this patch.


/Roman

Index: javax/swing/JPopupMenu.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/JPopupMenu.java,v
retrieving revision 1.15
diff -u -r1.15 JPopupMenu.java
--- javax/swing/JPopupMenu.java 12 Feb 2005 14:26:02 -0000      1.15
+++ javax/swing/JPopupMenu.java 1 Jun 2005 10:19:01 -0000
@@ -261,9 +261,6 @@
     constraints.weightx = 100.0;
     constraints.weighty = 100.0;
 
-    if (index == -1)
-      index = getComponents().length;
-
     constraints.gridy = index;
     super.add(component, constraints, index);