[cp-patches] Re: [RFA] JDWP packet classes

[Keith Seitz]

On Wed, 2005-06-01 at 12:45 -0600, Tom Tromey wrote:

> You forgot to refactor the ChangeLog entry :-)

Doh!

> Otherwise, just one more buglet.  With this fix it is ok, you don't
> have to post it again.
> 
> +     id = ((bytes[i++] & 0xff) << 24 | (bytes[i++] & 0xff) << 16
> +              | (bytes[i++] & 0xff) << 8 | bytes[i++]);
> 
> The final bytes[i++] needs an "& 0xff", as the byte value will be
> promoted to int and sign extended here.  I think there are a few cases
> of this.

Double doh! That's a typo. I did make that mistake, but my tests
actually pointed out that buglet. I just forgot to fix it before
reposting this patch. My bad.

> I think it is ok to check this in to libgcj and wait until you get a
> Classpath account for that side.

Committed. Thanks. On to the next set of patches.

Keith