Re: [cp-patches] RFC: GtkImage patch.

[Thomas Fitzsimmons]

Hi,

On Wed, 2005-06-01 at 08:41 +0200, Sven de Marothy wrote:
> Ok. This is my reimplementation of GtkImage.
> 

Awesome, thanks for tackling this tricky area of the peers!

>   public synchronized void setColorModel (ColorModel model)
>   {
>     // we can safely ignore this
>   }

Can you expand this comment and the one in setHints to explain why it is
safe to ignore these methods?

>   /**
>    * This is an old method, no idea if it's correct.
>    */
>   private int[] convertPixels (byte[] pixels)

Can this comment be removed?

> /* functions used by other gtk peer native routines */
> GdkPixbuf *gnu_java_awt_peer_gtk_GtkImage_getPixbuf(JNIEnv *env, jobject obj);
> GdkPixmap *gnu_java_awt_peer_gtk_GtkImage_getPixmap(JNIEnv *env, jobject obj);
> jboolean gnu_java_awt_peer_gtk_GtkImage_isOffScreen(JNIEnv *env, jobject obj);

Typically we declare functions used by multiple peers in gtkpeer.h.  Is
it necessary to use these long JNI-style names?

Otherwise, this looks great.

Thanks,
Tom