classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: fixlet for BasicButtonListener


From: Roman Kennke
Subject: [cp-patches] FYI: fixlet for BasicButtonListener
Date: Mon, 06 Jun 2005 13:41:35 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021204

The BasicButtonListener used to unarm the button on focusLost events. This behaviour is not documented anywhere and disturbs event processing in buttons (see https://savannah.gnu.org/bugs/?func=detailitem&item_id=13302 ). This is fixed now.

2005-06-06  Roman Kennke  <address@hidden>

   * javax/swing/plaf/basic/BasicButtonListener.java
   (focusLost): Don't unarm button on focus lost. This behaviour is
   not documented anywhere and disturbs correct event processing
   in buttons.

/Roman
Index: javax/swing/plaf/basic/BasicButtonListener.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicButtonListener.java,v
retrieving revision 1.9
diff -u -r1.9 BasicButtonListener.java
--- javax/swing/plaf/basic/BasicButtonListener.java     27 Apr 2005 08:31:34 
-0000      1.9
+++ javax/swing/plaf/basic/BasicButtonListener.java     6 Jun 2005 11:36:42 
-0000
@@ -87,9 +87,6 @@
     if (e.getSource() instanceof AbstractButton)
       {
         AbstractButton button = (AbstractButton) e.getSource();
-        ButtonModel model = button.getModel();
-        model.setArmed(false);
-
         if (button.isFocusPainted())
           button.repaint();
       }

reply via email to

[Prev in Thread] Current Thread [Next in Thread]