[cp-patches] Re: RFC: Fixed array index in GdkGraphics2D.updateBufferedImage

[Sven de Marothy]

On Tue, 2005-06-14 at 16:23 +0200, Ziga Mahkovec wrote:
> > Doing a pixel-by-pixel copy and conversion on EVERY DRAWING OPERATION is
> > quite wasteful as well. :-/ Really, let's keep our priorities in order
> > here :)
> 
> Right.  To elaborate: this path is not followed for the most common case
> -- single-bank (A)RGB-int sRGB-space images; however, as soon as one of
> these conditions isn't met, pixelConversionRequired gets set.

To elaborate even further: The conversion isn't being done for every
drawing operation. But there's still a lot of copying going on. :-/

> This sounds great.  I suppose this fix (with Robert's improvement) is
> still in place, for the time being?

I've no problems with that. I'm just a bit frustrated over how kludgy
this code is, and how there's no fix for it until the GTK-and-Cairo
stuff has been worked out.

-- 
Sven de Marothy <address@hidden>