[cp-patches] Re: [RFA/JDWP] ID factory

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <address@hidden> writes:

Keith> 2005-06-14  Keith Seitz  <address@hidden>
Keith>         * gnu/classpath/jdwp/id/JdwpIdFactory.java: New file.

Looks good.

Keith> +    /* ObjectId and ArrayId are special cases. See
Keith> +       end if newId. */

I think it should be s/if/of/

Keith> +            catch (InstantiationException ie)
Keith> +              {
Keith> +                // This really should not happen
Keith> +                throw new RuntimeException ("cannot create new ID");

It is generally better to chain exceptions.

Keith> +    /* getSuperclass returned null and no matching ID type found.
Keith> +       So there are only two choices left: an array or something
Keith> +       deriving from Object. */
Keith> +    if (object.getClass ().isArray ())
Keith> +      id = new ArrayId ();

If arrays are special you might as well check for this above, since
you know in advance that it won't appear in the table.  (This isn't an
important point for me though.)

Tom