Re: [cp-patches] [generics] RFC: VM interface changes

[Andrew John Hughes]

On Fri, 2005-06-17 at 15:29 +0200, Jeroen Frijters wrote:
> Hi,
> 
> Here is the first part of my proposed VM interface changes to make the
> VM interface more compatible with HEAD.
> 
> Please comment.
> 
> Regards,
> Jeroen
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

Two main comments, the rest is pretty much what I expected:

* If you change the environ() return type, then please change it to an
array as you suggested, so it becomes more type-safe.  The cast to
List<String> is pointless as it will check against List anyway at
run-time.  It brings up why I probably went with a list in the first
place; you don't know the size of the environment, without going over
the native structure twice (once to count, once to add to the array).
* The stubs seem to lose something.  Whereas before the type signature
handling may have been implemented by the VM, now it will always throw
an error even if the VM complies.  I'm okay if this is only a short-term
fix; I just don't like the idea of introducing such a stub for any
noticeable length of time (i.e. the next thing should be to implement
this).  There are already lots of places in the code where this is the
case, and we don't really want more.

(And am I the only one annoyed by the mailing list automatically
replying to sender?)

Thanks,
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
public class gcj extends Freedom implements Java { ... }

signature.asc
Description: This is a digitally signed message part