classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: JComponent.setOpaque should not issue a revalidate


From: Roman Kennke
Subject: [cp-patches] FYI: JComponent.setOpaque should not issue a revalidate
Date: Mon, 20 Jun 2005 16:37:13 +0200
User-agent: Mozilla Thunderbird 1.0.2 (X11/20050317)

The subject says it all. Additionally I think it should not call repaint, this should be handled by the L&F through a property change.

2005-06-20  Roman Kennke  <address@hidden>

   * javax/swing/JComponent.java
   (setOpaque): Don't revalidate and repaint when the opaque property
   is changed (at least not here).

/Roman
Index: javax/swing/JComponent.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/JComponent.java,v
retrieving revision 1.43
diff -u -r1.43 JComponent.java
--- javax/swing/JComponent.java 14 Jun 2005 22:29:45 -0000      1.43
+++ javax/swing/JComponent.java 20 Jun 2005 13:22:46 -0000
@@ -2161,8 +2161,6 @@
     boolean oldOpaque = opaque;
     opaque = isOpaque;
     firePropertyChange("opaque", oldOpaque, opaque);
-    revalidate();
-    repaint();
   }

   /**

reply via email to

[Prev in Thread] Current Thread [Next in Thread]