classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Patch: #13420 JInternalFrame default close operation


From: Anthony Balkissoon
Subject: [cp-patches] Patch: #13420 JInternalFrame default close operation
Date: Tue, 21 Jun 2005 18:39:56 -0400

This patch properly fixes JInternalFrame, JDialog, and JFrame accepting
invalid defaultCloseOperations.  As per 1.5, JFrame throws an invalid
argument error, but the other two allow (and store) the invalid operator
and default to DO_NOTHING_ON_CLOSE (tested against reference
implementation).

This passes Robert Schuster's Mauve test
gnu.testlet.javax.swing.JDialog.setDefaultCloseOperation.

2005-06-21  Anthony Balkissoon  <address@hidden>
        * javax/swing/JDialog.java:
        (setDefaultCloseOperation): Removed validity check for 
        operation code.  Validity is handled in processWindowEvent.
        * javax/swing/JFrame.java:
        (setDefaultCloseOperation): Changed error message to be more
        descriptive and similar to reference implementation.
        * javax/swing/JInternalFrame.java:
        (setDefaultCloseOperation): Removed validity check for 
        operation code.
        *javax/swing/plaf/basic/BasicInternalFrameUI.java:
        (InternalFramePropertyListener): Added implementation of
        VetoableChangeListener.
        (InternalFramePropertyListener.vetoableChange): New method.
        (InternalFramePropertyListener.propertyChange): Removed
        check for JInternalFrame.IS_CLOSED_PROPERTY.  This is now
        handled in vetoableChange.
        (getDesktopManager): Added a check for null pointer from 
        JInternalFrame.getDesktopPane().

This patch can be commited upon approval.

-Tony

Attachment: DefaultCloseOperation.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]