classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch for AbstractTableModel/DefaultTableModel - OK?


From: Roman Kennke
Subject: Re: [cp-patches] Patch for AbstractTableModel/DefaultTableModel - OK?
Date: Fri, 24 Jun 2005 15:08:23 +0200
User-agent: Mozilla Thunderbird 1.0.2 (X11/20050317)

David Gilbert wrote:

This patch fixes bug report 13422 and all (six) failing Mauve checks
(see before.txt and after.txt) for AbstractTableModel and DefaultTableModel:

2005-06-23  Dave Gilbert  <address@hidden>

        * javax/swing/table/AbstractTableModel.java:
        (getColumnName): eliminated temp index to fix very minor bug;
        (findColumn): throw NullPointerException for null argument;
        (fireTableDataChanged): set correct row indices.
        * javax/swing/table/DefaultTableModel.java:
       (setDataVector): replace null argument with empty vector then call
        setColumnIdentifiers() to set up column names;
        (getColumnName): for a column index beyond the number of columns in
        the model, pass control to the superclass.

OK to commit?

Looks ok. Please synchronize with my fixlet in DefaultTableModel and commit.

/Roman





reply via email to

[Prev in Thread] Current Thread [Next in Thread]