classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: Fixlet for Box


From: Roman Kennke
Subject: [cp-patches] FYI: Fixlet for Box
Date: Mon, 27 Jun 2005 16:55:51 +0200
User-agent: Mozilla Thunderbird 1.0.2 (X11/20050317)

I fixed two smaller issues in javax.swing.Box:

2005-06-27  Roman Kennke  <address@hidden>

       * javax/swing/Box.java
       (createGlue): Return Short.MAX_VALUE instead of Integer.MAX_VALUE as
       dimension in the Filler component.
       (createHorizontalGlue): Return a new Filler object with the correct
       value instead of relying on createGlue(). The object returned by
       createHorizontalGlue must not have a vertical dimension.

/Roman

Index: javax/swing/Box.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/Box.java,v
retrieving revision 1.13
diff -u -r1.13 Box.java
--- javax/swing/Box.java        22 Oct 2004 12:43:59 -0000      1.13
+++ javax/swing/Box.java        27 Jun 2005 14:54:21 -0000
@@ -192,7 +192,7 @@
   public static Component createGlue()
   {
     Filler glue = new Filler(new Dimension(0,0), new Dimension(0,0),
-                             new Dimension(Integer.MAX_VALUE,Integer.MAX_VALUE)
+                             new Dimension(Short.MAX_VALUE,Short.MAX_VALUE)
                              );
     return glue;
   }
@@ -211,7 +211,10 @@
    */
   public static Component createHorizontalGlue()
   {
-    return createGlue();
+    Filler glue = new Filler(new Dimension(0,0), new Dimension(0,0),
+                             new Dimension(Short.MAX_VALUE, 0)
+                             );
+    return glue;
   }
   
   /**

reply via email to

[Prev in Thread] Current Thread [Next in Thread]