Re: [cp-patches] RFC: Fixes for the Cairo bindings

[Thomas Fitzsimmons]

On Sat, 2005-06-25 at 16:53 +0200, Ziga Mahkovec wrote:
> This patch fixes some of the problems[1] Mark was having when running
> the Swing demo with Java2D/Cairo.  No text is shown yet due to some
> Pango issues, but at least the drawing part looks OK now:
> 
>   http://bootchart.org/misc/classpath/swing-j2d.png
> 
> It turned out the gdk_cairo_create calls were not really used, so this
> patch also removes the gtk-2.7 dependency.  The screenshot was made
> using gtk-2.6.7 and cairo-0.5.1.
> 
> Note that when running the Swing demo with jamvm, I had to increase the
> initial heap size (jamvm -Xms64m).  Otherwise it deadlocked in JNI when
> calling NewIntArray (I sent additional information to Robert).  The
> drawing is currently very slow, since Swing double buffering results in
> lots of GtkImage to BufferedImage conversions.
> 
> The patch also includes the MODE_JAVA_ARRAY fixes I posted[2] last week.
> 
> 
> OK to commit?

Yes please.

Thanks,
Tom