Re: [cp-patches] Needs Approval: Patch - JList multiple selection including Shift-Click

[Roman Kennke]

Am Mittwoch, den 29.06.2005, 15:49 -0400 schrieb Anthony Balkissoon:
> This patch improves JList's multiple selection capabilities, most
> notably by adding shift-click abilities.
> 
> Patch is attached.
> 
> Patch is pending approval.

Some nitpicks by me:

- No need to make every field private. This could impact performance in
some cases (like when inner classes access the private fields of
enclosing classes, the compiler has to generate accessor methods for
them).
- Try to separate API documentation changes from code changes.
- Inline comments should be written like this:
// This
// is
// a comment.
instead of /* ... */. The reason is, if I accidentally remove the /* or
*/ line (or comment it out with the comment-out feature of emacs), the
comment becomes code and borkes everything.

- Try to stay within 80 characters per line. Easier to read with most
editors.

If you could fix that, your code may as well go in. As I said, if it
doesn't break build or some common example progs, if it is documented
(API and inline) and is reasonable correct according to the specs and
Mauve and usability, your stuff can go in without waiting for approval.
If it _does_ break something, well, it can be fixed. :-D

/Roman