Re: [cp-patches] FYI: JTable changeSelection and multiple selection implementation

[Robert Schuster]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,
I have a small performance suggestion for the class in this patch.

> @@ -131,7 +141,7 @@
>      public void mouseDragged(MouseEvent e) 
>      {
>        curr = new Point(e.getX(), e.getY());
> -      updateSelection();      
> +      updateSelection(e.isControlDown());      
>      }
>      public void mouseEntered(MouseEvent e) 
>      {
> @@ -146,7 +156,8 @@
>      {
>        begin = new Point(e.getX(), e.getY());
>        curr = new Point(e.getX(), e.getY());
> -      updateSelection();
> +      updateSelection(e.isControlDown());
> +      
The Point instantiations will IMHO happen very often. I would change the
 code in a way that 'curr' and 'begin' are just updated with the new
values of 'e' instead of creating a new instance every time.

Ok to prepare a patch for this?

cu
Robert
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFCxGkkG9cfwmwwEtoRAuKcAJ9P6JV+PRiy8zCBbGkvqlylDLov6wCgiX2O
Tb1xJom+w1De8IcyLTYoAaw=
=rxSx
-----END PGP SIGNATURE-----