Re: [cp-patches] FYI: Adding read/write to javax/swing/text/JTextComponent.java (fixing bug #13640)

[Meskauskas Audrius]

> reading in bigger chunks?


Hello, Tom

This depends on from where we read. I thought the user will use our 
BufferedReader to cover the multiple components being read. The optimal 
buffer size should be larger than the size of the text, stored in the 
typical Swing component (labels, buttons, menu items and so on, I think, 
normally contain 16-20 characters at most, but more frequently 6-8 or 
about).

Cheers
Audrius

Tom Tromey wrote:

> > > > > > "Audrius" == Meskauskas Audrius <address@hidden> writes:
> > > > > >            
>
> Audrius> +    StringBuffer b = new StringBuffer();
> Audrius> +    int c;
> Audrius> +
> Audrius> +    // Read till -1 (EOF).
> Audrius> +    while ((c = input.read()) >= 0)
> Audrius> +      b.append((char) c);
>
> Ouch.  How about reading in bigger chunks?
>
> Tom
>
>
>